search

openapi-tools / jackson-dataformat-hal

Dataformat extension for Jackson to handle HAL JSON
MIT License
24 stars 6 forks source link

Allow Strings and URIs for the @Link annotation when serializing #27

Open andreas-eberle opened 4 years ago

andreas-eberle commented 4 years ago

With this PR, it becomes possible to use the @Link annotation with Strings and URIs making the library less intrusive and easier to use.

Code Example:

        @Link
        public String stringLink = "http://something.com";

        @Link
        public URI uriLink = new URI("http://something.else.com");
codecov[bot] commented 4 years ago

Codecov Report

Merging #27 into master will increase coverage by 0.25%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #27      +/-   ##
============================================
+ Coverage     77.27%   77.52%   +0.25%     
  Complexity       63       63              
============================================
  Files            10       10              
  Lines           352      356       +4     
  Branches         67       69       +2     
============================================
+ Hits            272      276       +4     
  Misses           72       72              
  Partials          8        8
Impacted Files Coverage Δ Complexity Δ
.../jackson/dataformat/hal/ser/HALBeanSerializer.java 84.96% <100.00%> (+0.46%) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2834e1...9443455. Read the comment docs.

andreas-eberle commented 4 years ago

@langecode: Could you have a look at this PR?

langecode commented 4 years ago

..and again thanks for the contribution. I had not noticed your PR before the mention, sorry.