jimhooker2002 commented 6 years ago

As the title suggests - just scratched out something quickly to show what I'm thinking. If it looks like this is going in the right direction then I can add tests, tidy-up etc.

Note - the only testing I've done on this so far is that it compiles and the existing tests pass. Far from "production" ready just yet.

codecov[bot] commented 6 years ago

Codecov Report

Merging #5 into master will decrease coverage by 7.98%. The diff coverage is 22.22%.

@@             Coverage Diff              @@
##             master       #5      +/-   ##
============================================
- Coverage     70.07%   62.09%   -7.99%     
  Complexity       46       46              
============================================
  Files             9       10       +1     
  Lines           264      306      +42     
  Branches         51       59       +8     
============================================
+ Hits            185      190       +5     
- Misses           73      107      +34     
- Partials          6        9       +3

Impacted Files	Coverage Δ	Complexity Δ
...ls/jackson/dataformat/hal/SimpleCURIEProvider.java	`0% <0%> (ø)`	`0 <0> (?)`
...openapitools/jackson/dataformat/hal/HALMapper.java	`36.36% <0%> (-13.64%)`	`2 <0> (ø)`
.../dataformat/hal/ser/HALBeanSerializerModifier.java	`100% <100%> (ø)`	`3 <1> (ø)`	:arrow_down:
.../jackson/dataformat/hal/ser/HALBeanSerializer.java	`67.25% <12.5%> (-15.89%)`	`3 <0> (ø)`
...tools/jackson/dataformat/hal/JacksonHALModule.java	`66.66% <60%> (-33.34%)`	`2 <1> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eddef1e...45079b5. Read the comment docs.

jimhooker2002 commented 6 years ago

Closing in favour of https://github.com/openapi-tools/jackson-dataformat-hal/pull/6 based on previous feedback.

openapi-tools / jackson-dataformat-hal

First attempt, basic solution sketch. #5

Codecov Report