openapistack / openapi-client-axios

JavaScript client library for consuming OpenAPI-enabled APIs with axios

https://openapistack.co

MIT License

558 stars 67 forks source link

simple fix to escape method names in typegen #32

Closed jeongY-Cho closed 4 years ago

jeongY-Cho commented 4 years ago

A stopgap solution to #26.

operationId is turned into a string instead.

A more permanent solution would be to use the same type name converter that the dtsgenerator uses for operationId's in order to sanitize both the method names and type definitions.

anttiviljami commented 4 years ago

This is no longer needed now that #34 was merged, right ?

tannerntannern commented 4 years ago

This is no longer needed now that #34 was merged, right ?

34 says "in conjunction with with #32", so I think this still needs to be merged.

anttiviljami commented 4 years ago

Right. I guess this makes things safer anyways. Thanks for your input @tannerntannern !

jeongY-Cho commented 4 years ago

Yyes, @tannerntannern is right. Both were branched from the same place.