openapistack / openapi-client-axios

JavaScript client library for consuming OpenAPI-enabled APIs with axios
https://openapistack.co
MIT License
550 stars 67 forks source link

fix(type) : Remove extra $ in responses types #90

Closed gterral closed 2 years ago

gterral commented 2 years ago

Hello !

Thank you very much for this library 🙏 ! At Pennylane, we use it a lot to improve the communication between our frontend & backend engineers. 🎉

Since we updated the library's version, in the client.d.ts file, the responses's types have been prefixed with a " $ ". I guess that is because the "$" is now added by the dts-generator library ?

How to reproduce : Run ./typegen ../__tests__/resources/example-pet-api.openapi.yml and have a look at the generated ts file. You will see that each response type is something like OperationResponse<Paths.OperationId.Responses.$$200> .

I was wondering if you will be ok to remove the extra "$". 

I didn’t see any contributing guides, so let me know if I’ve done something wrong.



Thanks,

anttiviljami commented 2 years ago

Thank you so much @gterral !