search

openaq / openaq-api

OpenAQ Platform API - NO LONGER IN USE see https://github.com/openaq/openaq-api-v2
Other
150 stars 43 forks source link

Duplicate locations for Nepal #321

Closed amritsharma closed 7 years ago

amritsharma commented 7 years ago

If you look at the air quality stations listed for Nepal page on OpenAQ website, you'll notice there are 4 areas and 4 locations. But, there are actually only 2 of each:

  1. "US Diplomatic Post: Embassy Kathmandu" and "US Diplomatic Post: Kathmandu" are the same.
  2. "US Diplomatic Post: Phora Durbar" and "US Diplomatic Post: Phora Durbar Kathmandu" are the same.

The issue started a couple weeks ago when the URL of the XML files for Nepal air quality stations, and an awesome community member updated OpenAQ code to match that. It looks to me like this issue was a side effect of that. Ideally, the fix would involve merging the duplicate locations into one, but I don't know if that's feasible or a good idea based on our current architecture.

Use case: This is an issue for me when I want to find out which stations in Nepal haven't reported any data in a while... and the 2 "older" stations come up, even though they're the same as the other two that are currently recording and reporting data.

jflasher commented 7 years ago

Somewhat related to https://github.com/openaq/openaq.org/issues/200. Basically the underlying data source changed the location name. I'm just going to go ahead and make them all match the new ones since the underlying data source shouldn't be changing anymore. For other sources, I'm less inclined to do this if location names keep shifting.