search

openaq / openaq-metadata-editor

MIT License
1 stars 1 forks source link

Form validation on save only #52

Closed olafveerman closed 5 years ago

olafveerman commented 5 years ago

Proposal to perform validation of the form on save only.

Current behavior

Any edit to the form triggers form validation and immediately highlights the required fields in bright red.

Expected behavior

After filling in the form and hitting save, the form is validated, highlighting the errors.

necoline commented 5 years ago

@sethvincent What was the reason behind validating on propUpdate From what I can tell, if we are validating the form before we update here, it works just fine. I know on our call, you mentioned some trickery with validating json objects, so maybe I'm overlooking something?

sethvincent commented 5 years ago

@necoline great, it looks like that’s an easier fix than I expected.

necoline commented 5 years ago

You can see the fix here: #55

sethvincent commented 5 years ago

closed by #55