search

openark / orchestrator

MySQL replication topology management and HA
Apache License 2.0
5.64k stars 936 forks source link

tests/integration/instance_dao_test.go has many undefined references #600

Open bbuchalter opened 6 years ago

bbuchalter commented 6 years ago 
go test github.com/github/orchestrator/tests/integration
# github.com/github/orchestrator/tests/integration
tests/integration/instance_dao_test.go:39:17: undefined: InstanceKey
tests/integration/instance_dao_test.go:43:17: undefined: InstanceKey
tests/integration/instance_dao_test.go:47:17: undefined: InstanceKey
tests/integration/instance_dao_test.go:51:17: undefined: InstanceKey
tests/integration/instance_dao_test.go:76:2: undefined: ExecInstance
tests/integration/instance_dao_test.go:77:2: undefined: ExecInstance
tests/integration/instance_dao_test.go:78:2: undefined: ExecInstance
tests/integration/instance_dao_test.go:87:10: undefined: ReadTopologyInstance
tests/integration/instance_dao_test.go:97:10: undefined: ReadTopologyInstance
tests/integration/instance_dao_test.go:104:10: undefined: ReadTopologyInstance
tests/integration/instance_dao_test.go:104:10: too many errors
FAIL    github.com/github/orchestrator/tests/integration [build failed]

I'm new to go, and would welcome trying to fix this on my own, but I'm a bit stumped. The missing references are all part of the inst package, to which this file is a part of. Is the problem that it is not in the go/inst directory? But there is already a test file with the same name in that directory...maybe this one is no longer needed?

shlomi-noach commented 6 years ago

Ah yes, thank you for pointing this out. This test is not currently in use. I moved the file with intentions to redesign the tests, and never made it. Wow, it's been two years.

Let me take another look at it.

shlomi-noach commented 5 years ago

@bbuchalter I'm guessing you closed this due to inactivity on my side. I'm sorry for the long stall, to be honest this got buried under multiple other things. I'd still like to work on this.