openark / orchestrator

MySQL replication topology management and HA
Apache License 2.0
5.62k stars 927 forks source link

Show InstanceAlias in GUI and/or cli orchestrator -c topology if provided #702

Open sjmudd opened 5 years ago

sjmudd commented 5 years ago

This is just a reminder as I may try to fix this if I get time.

If you use orchestrator with Vitess one of the parameters that orchestrator can pass when doing a master failover is {successorAlias}. This is the alias of the new master. While there's already the <instance>:<port> info Vitess doesn't really understand that.

Currently this alias is not visible in the GUI.

You may have servers named something like <hostname>:<port> and in cloud environments these names may not mean much. Vitess has its own naming convention of the form <cell>-<tablet_id> where cell is basically a datacentre or availability zone and the tablet_id tends to be a 10-digit unique number. e..g cell1-0000001000.

If you are managing vitess seeing these tablet aliases is convenient even if the instances have their own names.

So I'd like to see, where the Alias is defined, that perhaps the hostname shown in the GUI can be shown as hostname:port (cell-0000001234) to make it easier to quickly identify the mysql instance in terms of mysql usage or vitess usage.

shlomi-noach commented 5 years ago

@sjmudd I intend to solve the above (literally the exact issue) via instance tags: https://github.com/github/orchestrator/pull/664

I have multiple use cases for tagging, this is just one of them.