search

openark / orchestrator

MySQL replication topology management and HA
Apache License 2.0
5.64k stars 933 forks source link

Add 'GTID' to button name #713

Closed utdrmac closed 5 years ago

utdrmac commented 6 years ago

https://github.com/github/orchestrator/blob/113d3ba9238063a8c16a9e78a927b51cc6d68cbe/resources/templates/layout.tmpl#L216

When viewed in the GUI, this button just says "Enable" with no tooltip or other indication of what its purpose is. Not until you click the button are you presented with a box that asks if you want to enable GTID. If the button was labeled "Enable GTID", it would clear what it is for.

Same for when this button says 'Disable' and the other button that just says "Fix" (maybe "Fix Errant GTID"?)

shlomi-noach commented 6 years ago

But, the button is in the context of a GTID based replication line. I would think it would be superfluous to name the button "Enable GTID based replication".

screen shot 2018-11-14 at 07 18 31

Likewise, the "Fix" button comes in a "GTID errant" context, renaming it to "Fix errant GTID" would be superfluous.

screen shot 2018-11-14 at 07 49 31

What do you think?

utdrmac commented 5 years ago

I think we are looking in different locations. I'm referring to the very bottom of a server config box. It just says "Enable". Even if you mouse-hover, it doesn't say anything about GTID. Not until you actually click it, does it prompt you to enable GTID.

screen shot 2018-11-14 at 2 23 15 pm
shlomi-noach commented 5 years ago

Then this is a bug.

shlomi-noach commented 5 years ago

I'm unable to reproduce this, and for me the button appears in the correct context. Could you screenshot the entire pop up dialog please?

screen shot 2018-11-15 at 07 56 04

utdrmac commented 5 years ago
screen shot 2018-11-15 at 12 29 36 am screen shot 2018-11-15 at 12 29 46 am
shlomi-noach commented 5 years ago

addressed by https://github.com/github/orchestrator/pull/717

shlomi-noach commented 5 years ago

As per https://github.com/github/orchestrator/pull/717#issuecomment-439149247 button appears on bottom instead of on relevant row, when enabled.

shlomi-noach commented 5 years ago

This fixes the button not showing when GTID is not possible, but when possible to enable, the button still shows at the bottom and still only says the word "Enable". There is not any indication this "Enable" button refers to GTID.

@utdrmac this does not reproduce for me. Could you please Shift-Refresh to make sure the latest js files are loaded into browser's cache?

shlomi-noach commented 5 years ago

woot! Just reproduced, on a dead/unseen server.

utdrmac commented 5 years ago

Sweet. Sorry I couldn’t reply; been traveling for holiday.

On Nov 21, 2018, at 3:14 AM, Shlomi Noach notifications@github.com wrote:

woot! Just reproduced, on a dead/unseen server.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.