search

openark / orchestrator

MySQL replication topology management and HA
Apache License 2.0
5.61k stars 927 forks source link

Orchestrator 3.0.13 does not show MIXED for servers where binlog_format is MIXED #853

Open sjmudd opened 5 years ago

sjmudd commented 5 years ago

I noticed when upgrading some 10.2 to 10.3 MariaDB servers that given the my.cnf changes where 10.3 uses binlog_format = MIXED by default vs STATEMENT in 10.2 that orchestrator did not show this in the GUI.

Normally I see servers with STATEMENT or ROW but the couple of boxes with MIXED had no label which I'd expect. Clearly this is not urgent but it's convenient to see the mode being shown.

Also orchestrator -c topology and orchestrator-client seem to behave the same way.

I would expect that the GUI and orchestrator or orchestrator-client would also explicitly show MIXED if that's how binlog_format is configured.

sjmudd commented 5 years ago

Note: I don't particularly like MIXED format but it's good to see this if that's how your server is configured.

shlomi-noach commented 5 years ago

Followup to private discussion, can you please check if binary logs are enabled for those replicas? MIXED should generally show just fine; but perhaps bin logs are disabled, in which case the binlog_format is not displayed.

sjmudd commented 5 years ago

Screenshot 2019-03-28 at 16 13 12

sjmudd commented 5 years ago

So binlogs are not enabled on the boxes concerned. As discussed I guess my concern is that given 10.3+ has change in the default setting vs earlier versions or Oracle's MySQL that there may be an issue that the setting being different won't be visible. Should you change the configuration (e.g. add binlogs) and not notice) it might be possible to inadvertently use MIXED which may be undesired.

That may just be a bad perception from my side. The explicit MIXED (might because of this) be better and there's in the GUI also a this has a binlog icon anyway which may have confused me.

If orchestrator handles the setting correctly whether the slave has binlogs or not then maybe I shouldn't care.

So if you think this is a non-issue thanks for considering: just let me know.