search

openassistant / oa-core

Open Assistant Core
http://openassistant.org
GNU General Public License v3.0
293 stars 77 forks source link

Core Attributes and Modules #3

Closed joshuashort closed 6 years ago

joshuashort commented 6 years ago

The biggest change here is removing auto-create and auto-execute for Core attributes.

I kind of like the idea, but I wanted to remove a source of bugs -- setting something to an incorrectly-spelled or -scoped attribute would succeed without problems, and subsequent calls to access a non-existent property wouldn't give any feedback about a problem. It's now possible/easy to use normal Python idioms to do things like check if a property exists. Also, there will be errors when something goes wrong.

A lot of little things got updated/cleaned in order to get things running again -- specifically how parts/abilities/minds access/set properties. Some abilities are still broken, but it's only a problem when they're used. The essential pieces should work.

Module/mind/part loading also got some attention to prep for more robust plugins.

vavrek commented 6 years ago

Incredible work Josh! Really appreciate this attention you are paying to development flow and how many details you are providing along the way. Will help everyone involved understand this system better. Diving into the code with Jenya today. Thank you so much for improving everything!