openatv / enigma2

openatv-gui
GNU General Public License v2.0
200 stars 314 forks source link

Known po translation file issues #1789

Closed wedebe closed 5 months ago

wedebe commented 4 years ago

Using this to track po file issues.

wedebe commented 4 years ago

Could someone assign this to me, please?

nickersk commented 4 years ago

there you go

jbleyel commented 2 years ago

Can we close this?

wedebe commented 2 years ago

A significant amount of (but noticeably not all) translation work was lost with the implementation of Weblate (I had been updating en.po rather that .py/.xml files directly up to that point).

I notice there are currently contributions being made to the English translation which differ from that previous work.

jbleyel commented 2 years ago

We plan to fix all strings in source to the correct en_US spelling. en.po will be stay empty.

jbleyel commented 2 years ago

If you find wrong text in source then feel free and send me the corrected file. Please do not change the source in git directly because I also need to fix the pot/po files.

wedebe commented 2 years ago

We plan to fix all strings in source to the correct en_US spelling. en.po will be stay empty.

May I suggest that you use the version of translations at this commit: https://github.com/openatv/enigma2/blob/7c8c88df5775cde7ec516e2765d5286f54a7828a/po/en.po

This was at the point of simplified, more-consistent English terminology, grammar and punctuation.

wedebe commented 2 years ago

If you find wrong text in source then feel free and send me the corrected file. Please do not change the source in git directly because I also need to fix the pot/po files.

Do the po/updateallpo.sh and po/updatepot.sh scripts still work as intended for Weblate?

It would be handy to update the translation contribution section of the Readme.

jbleyel commented 2 years ago

We plan to fix all strings in source to the correct en_US spelling. en.po will be stay empty.

May I suggest that you use the version of translations at this commit: https://github.com/openatv/enigma2/blob/7c8c88df5775cde7ec516e2765d5286f54a7828a/po/en.po

This was at the point of simplified, more-consistent English terminology, grammar and punctuation.

Is this en_US or en_GB?

jbleyel commented 2 years ago

If you find wrong text in source then feel free and send me the corrected file. Please do not change the source in git directly because I also need to fix the pot/po files.

Do the po/updateallpo.sh and po/updatepot.sh scripts still work as intended for Weblate?

It would be handy to update the translation contribution section of the Readme.

I use the GitHub Action to create the pot file. But this is only for new strings. Existing strings needs to changed differently and I also update the files for weblate. The workflow is not that easy but it's working.

jbleyel commented 2 years ago

We will lose all existing translations if we only fix the source and update the pot file only. This is not my style.

IanSav commented 2 years ago

@jbleyel and I have been talking about creating some language style guides for all future text changes in Enigma2.

Some of the key points, so far, include:

  1. All text in code must be in en_US (English US).
  2. There is no need for any text to be translated in en.po or en_US.po.
  3. English text should not be compromised to suit any single alternate language. Where translation issues present themselves reasonable compromises should be discussed. For example "Storage" can be ambiguous in some translations so an additional word, like "Disk Storage" or "RAM Storage" may help for translations yet still keep the English meaning intact.
  4. All titles and button should have the first letter of every word capitalised.
  5. When titles or buttons are referenced in text the capitalization should be retained.
  6. All references to buttons on the remote control should be in all upper case. E.g. OK, RED, GREEN, MENU, etc.
  7. All descriptions text should be written in concise English with proper and appropriate punctuation.
  8. Currently help text does not include punctuation but this is up for review.
  9. There should only be one space after punctuation marks. Extra spacing for readability to separate options etc may still be appropriate.

These two documents and the link are some common writing style guides that are very popular:

This is a work in progress. Suggestions, corrections and enhancements welcomed.

jbleyel commented 5 months ago

Continue here -> #3310