openatv / enigma2

openatv-gui
GNU General Public License v2.0
200 stars 317 forks source link

Feature Request: `Install local extension` acts differently to PluginManager when installing picons #2321

Closed wedebe closed 1 year ago

wedebe commented 2 years ago

The option to select picon location to install to isn't presented when installing ipk from filesystem.

However, downloading (often outdated) picon plugins through the Plugin Browser provides options.

Request: present location options when installing local picon-* extensions.

PluginBrowser.py:

                if self["list"].l.getCurrentSelection()[0].name.startswith("picons-"):
                    supported_filesystems = frozenset(('vfat', 'ext4', 'ext3', 'ext2', 'reiser', 'reiser4', 'jffs2', 'ubifs', 'rootfs'))
                    candidates = []
                    import Components.Harddisk
                    mounts = Components.Harddisk.getProcMounts()
                    for partition in harddiskmanager.getMountedPartitions(False, mounts):
                        if partition.filesystem(mounts) in supported_filesystems:
                            candidates.append((partition.description, partition.mountpoint))
                    if candidates:
                        from Components.Renderer import Picon
                        self.postInstallCall = Picon.initPiconPaths
                        self.session.openWithCallback(self.installDestinationCallback, ChoiceBox, title=_("Install picons on"), list=candidates)
                    return
jbleyel commented 1 year ago

This feature has been removed and is now implemented differently.

wedebe commented 1 year ago

This feature has been removed and is now implemented differently.

I noticed this change this morning, thanks!