search

openatv / enigma2

openatv-gui
GNU General Public License v2.0
200 stars 314 forks source link

[File Commander] Status bar notification style #2832

Open wedebe opened 1 year ago

wedebe commented 1 year ago

! Before you log an issue, have you updated to the most recent version? It's possible the issue may have already been fixed.

Describe the bug / Actual behaviour: File Commander uses a non-standard (and, tbh, ugly) method of notifying users of actions performed. yuk-screenshot_20230426050356

Expected behaviour: 20230426133503

Has this issue started to happen just recently? No, it has been a problem for quite a while.

To reproduce: Steps to reproduce the behavior:

  1. Open File Commander
  2. Delete a file

Screenshots See above

Image/Box Model (please complete the following information):

Additional context n/a

jbleyel commented 1 year ago

This is by purpose because the Messagebox is annoying here. That’s why we have implemented the status bar.

IanSav commented 1 year ago

When we were developing the code we found all the pop up windows to be intrusive. Further the windows needed to be acknowledged which required extra button clicks. If we used timed popups they were either closed too fast to read the message or stayed on screen for too long and interrupted the work flow.

Give this explanation, if you still think this is wrong (is a bug) then I would be interested to see how you would deal with this issue.

wedebe commented 1 year ago

Ok, not a bug but certainly needs improvement. The Status Bar component could really do with some input from the designer(s) of MetrixHD skin. Even the position doesn't seem... right. Perhaps...

jbleyel commented 1 year ago

The new status bar is fully skinable.

-> https://github.com/openatv/MetrixHD/blob/7.1/usr/share/enigma2/MetrixHD/skinfiles/skin_plugins.xml#L2903 -> https://github.com/openatv/MetrixHD/blob/7.1/usr/share/enigma2/MetrixHD/skinfiles/skin_plugins.xml#L2951

IanSav commented 1 year ago

Ok, not a bug but certainly needs improvement. The Status Bar component could really do with some input from the designer(s) of MetrixHD skin. Even the position doesn't seem... right. Perhaps...

  • moving it to between the paths and column headers

This is not free space. This space is for long file paths. Though you can put it there in your own skin if you like.

  • re-using the highlight colouration (in this case, white on blue background)

This is skin-able.

  • drop the drop-shadow

This is skin-able.

  • and re-using the Message Box icon per success/error staus

This is not so easy as this is a text only widget.

would be a more pleasing-to-the-eye approach?

@jbleyel and I workshopped a number of ideas before deciding that this was the best option of all the ideas we came up with. That said, if you want to have all the pop ups then this could be added. I would insist it be optional as I can assure you that all the pop ups generated will drive you to distraction.

wedebe commented 1 year ago

I guess the closest equivalent from a web design world would be the MUI snackbar: https://m2.material.io/components/snackbars

...in particular placement. My biggest issue really is the gawdawful yellow and text shadow!

wedebe commented 1 year ago

Are there other variations (colours) for, eg. errors?

jbleyel commented 1 year ago

There is only one status bar color without any icon in the current skin. We need to change the code and all skins if you wanna have different colors and different icons.