System Information: extra indent

[AbuBaniaz]

! Before you log an issue, have you updated to the most recent version? It's possible the issue may have already been fixed. OpenATV 7.3. 19 May 2023. Flashed by USB. TM Nano OE

Describe the bug / Actual behaviour: [[A clear and concise description of what the bug is.]] Extra tabs on page. See screenshot Menu > Information > Receiver > Yellow (System Information)

Expected behaviour: [[A clear and concise description of what you expected to happen.]] All the text should be in line. It isn't a matter of length. Even isa has an extra tab.

Has this issue started to happen just recently? Just tried now, so not sure when it started

To reproduce: Menu > Information > Receiver > Yellow (System Information)

Screenshots

Image/Box Model (please complete the following information): OpenATV 7.3. 19 May 2023. Flashed by USB. TM Nano OE

[IanSav]

This is actually a bug in the rendering code. The space used by a TAB is being calculated incorrectly. The cause of this will be investigated by people more familiar with the C++ code.

I have just checked and fixed issues in the ScrollLabel control and verified that this issue is to do with TAB processing.

[jbleyel]

Step 1: https://github.com/openatv/enigma2/commit/927157f0675b2a03e7aa2d96ea8f11e079b4acd0

This is only one part of the fix.

[wedebe]

Is this a page that would lend better to box/table layout? Translations will cause the max length of labels to differ (indeed here there's an excess of space before the semicolons).

[jbleyel]

What you mean with translation? This screen is a full dump of a console command output. And we only have fixed the tab position.

[wedebe]

What you mean with translation? This screen is a full dump of a console command output. And we only have fixed the tab position.

Ah I see, I thought the labels were coded into the xml/py.

Re translation, I meant something like:

CPU Mhz: 404.998 or Der prozessor hardware centrale Mhz: 404.998

[AbuBaniaz]

As a separate thing, other images rounded up/down those speeds. Should be 405 MHz.

[IanSav]

As @jbleyel pointed out these screens are not processed or calculated by Enigma2. They are the output of core shell commands. The original report highlighted an issue in Enigma's TAB processing. This will be fixed for all screens that use a fixed pitch font. Using TABs in a kerned font is not so easy and will not be tacked in this instance.

[wedebe]

Using TABs in a kerned font is not so easy and will not be tacked in this instance.

I don't think it's worth changing from monospace text in this case!