openatv / enigma2

openatv-gui
GNU General Public License v2.0
200 stars 317 forks source link

`Record` menu item numbers differ #3094

Open wedebe opened 1 year ago

wedebe commented 1 year ago

! Before you log an issue, have you updated to the most recent version? It's possible the issue may have already been fixed. 2023-10-24

Describe the bug / Actual behaviour: Menu items in the Record menu are assigned various numbers. As elsewhere (eg. Channel List context menu), each item should be assigned a designated number so users can quickly and easily do what they need, instead of having to visually scroll the menu.

Eg:

(Button)        (Action)
1                   Stop recording
1 2             Record event
  2 3               Record indefinitely
    3 4             Record duration
      4 5           Record until time
          6         Change recording duration
            7       Change recording end time
        5     8     Stop timer recording
        5 6   8 9   Do not record

Expected behaviour:

An example:

1 Record event
2 Record indefinitely
3 Record duration
4 Record until time
5 Change recording duration
6 Change recording end time
7 Stop recording*
8 Stop timer recording
0 Do not record

With a timer recording and no instant recording in progress:

1 Record event
2 Record indefinitely
3 Record duration
4 Record until time
8 Stop timer recording
0 Do not record

Has this issue started to happen just recently? No, has always been an issue

To reproduce: Steps to reproduce the behavior:

  1. Set various combinations of timer and instant recording and check the Record menu
  2. Observe number change for specific items (eg. Do not record can be any of , 6, 8, or 9)

Screenshots rec-no-timer-20231026221428 rec-instant-20231026221701 rec-timer-20231026220924 rec-instant timer-20231026221749

Image/Box Model (please complete the following information):

Additional context *Adding a hotkey of Stop button for Stop recording would be a nice bonus for this menu, or display ⬛ Stop recording in place of the number 7?

GhostofGeeeee commented 1 year ago

The feature is that you get numbers and don't need to scroll(like you said(having to visually scroll the menu)). Usually you start on 1 and 2... You want a new feature! and you like to remember all menus with numbers!

wedebe commented 1 year ago

I often feel that only some of the effort I've put into logging issues here is actually read. Specifically, in this instance: As elsewhere (eg. Channel List context menu), each item ... assigned a designated number so users can quickly and easily do what they need

20231027231330

I don't often add new channels to my bouquets, but I know that pressing Menu, 5, OK without even looking at the screen will always `Add [the current] service to [my Favourites] bouquet.

Having the number change depending on circumstance, I might as well look at the screen and keep my thumb at the Down and OK buttons (which will action thee highlighted item) rather than run the risk of pressing the wrong number (which could possibly perform an unintended action). When there are up to 9 options and the order in which they appear changes frequently, the user has to keep reading through a list every time it appears to find the option they want.

Random menu item numbers cause difficulty for people with dyslexia, as well as mobility issues or those who use assistive technologies which work best when shortcuts are fixed per action.

" the thing about minor inconveniences, is that they can accumulate over time and cause a big meltdown. Some of these common inconveniences are:

IanSav commented 1 year ago

What you post is read but you appear to want is coders to be waiting for your feedback so they can jump on making the changes. Speaking for myself, I have Enigma code changes in the todo list that will take months, if not years, to complete.

I am very keen to address UI inconsistencies and want to make many more improvements to the UI. In this case, I would like to complete the rewrite of MessageBox that will consume and replace ChoiceBox before changing code that uses these screens.

GhostofGeeeee commented 1 year ago

It looks that this issue is important for you, maybe im not specific enough.(sorry, I can't feel the bug) There are menus (without numbers,) with numbers and with fixed numbers. You found one without fixed numbers. Is that a bug? No, this feature isn't added there. You can think and ask about add this!

Personal I use this menu too. I like that "Stop recording" comes to the top if available and... and never used numbers on it. -> I haven't a problem if they come fixed. It could be a new feature (but not for me).

To respect the words of @IanSav (and I hope, I do it! Thank you!)

More to say? Yes, but I don't like. Finally, I'm not sure that a dyslexic are happy on a menu with unsorted numbers!