search

openatv / enigma2

openatv-gui
GNU General Public License v2.0
200 stars 317 forks source link

LCDPicon Renderer #3100

Closed jbleyel closed 11 months ago

jbleyel commented 11 months ago

The LCDPicon Renderer find not all picons like the Picon Renderer. The LCDPicon should be a subclass of Picon.

AbuBaniaz commented 11 months ago

It should really import the names from the image's picon renderer.

Papi2000-new commented 11 months ago

not really. You may have a set of brightly colorful picons for the gui skin. but on boxes with only bw-display it may be helpfull, to have a set of simple designed picons for that simple displays. Therefore the set for displays can be a sub-set of the gui picons (folder picon_lcd within the folder picon), or at the same folder level as /picon,

/usr/share/enigma2/picon /usr/share/enigma2/picon/picon_lcd

or

/usr/share/enigma2/picon /usr/share/enigma2/picon_lcd ...

jbleyel commented 11 months ago

You miss the point, there is a difference in the picon name calculation routine of these 2 renderer. This means the picon will not displayed with LCDPicon but it will displayed with Picon.

AbuBaniaz commented 11 months ago

Name of picon, not location of picon. ATV/Vix and whoever has forked from them allow people to have one set of picon for OSD and another set for front panel display (LCD).

On Vix, there is a separate picon renderer for the front panel display /LCD picon. It used to separately derive the picon name, Simon capewell changed it so it derives/imports the name from the picon renderer. I'll post link to commit later.

I think ATV still does same thing (work out lcd/front panel display picon name separately). Actually, I think lots of skins do the same thing (work out picon name separately). Possibly why SNPicons not as popular for ATV users. Been a while since I checked, so apologies in advance if incorrect.