search

openatv / enigma2

openatv-gui
GNU General Public License v2.0
200 stars 317 forks source link

Q: Refactor Picon Path Calculation #3126

Open jbleyel opened 10 months ago

jbleyel commented 10 months ago

The current picon search function is based on all mounted devices with a picon subfolder and in addition a lcdpicon subfolder. That means all of these folders will be scanned for each picon all the time.

My plan is to remove that completely. The new search function will only search in one folder and this folder can be defined as setting.

Any objections?

Papi2000-new commented 10 months ago

Yes, this sounds pretty good (but the skinner will have once again another construction set). But in fact, that can be the future. Maybe, in combination with picon_lcd for separate picons for lcd (better contrast in b/w)?

wedebe commented 10 months ago

Sounds good.

Ideally, the Picon install path Plugin Manager setting would be moved to... Channel Selection Settings?

Picon path could be set to Automatic, which would - on bootup - scan/probe mounts and save the found path as a variable to be called from a getPiconFolder (or getPiconDirectory)

OR... On bootup, mount the found picon folder if not /picon (eg. /media/mmc/picon) to /picon, such that /picon is always available.

jbleyel commented 10 months ago

Move Picon install path to Channel Selection Settings is wrong because this is the wrong context.

AbuBaniaz commented 9 months ago

I hope you allow users to have one folder for LCD picons and another for the osd ones.

jbleyel commented 9 months ago

I hope you allow users to have one folder for LCD picons and another for the osd ones.

Yes. That’s one of reasons why i wanna refactor.