openatv / enigma2

openatv-gui
GNU General Public License v2.0
200 stars 317 forks source link

hotkey setup #3334

Closed popking159 closed 4 months ago

popking159 commented 4 months ago

Is your feature request related to a problem? Please describe. In Hotkey setup , it was available to assign a key for volume dwon and volume up , then it was deleted , then it is back again , it is good to be present but there is a problem , if i assign cross_left button for volume down , it works but each click on the cross_left button decreases the volume by one step , and if i hold the key , no acton and it is defined as unhandled key , the good function is to hold the cross_left key and the volume continues to decrease ,

Describe the solution you'd like make the assignment with flage "r"

Describe alternatives you've considered may be modify class InfoBarChannelSelection in InfoBarGennerics.py by adding this :

"volumeUp": (self.volumeUp, _("change Volume up")),
"volumeDown": (self.volumeDown, _("change Volume down")),

Additional context 1infobarge

regards

jbleyel commented 4 months ago

https://github.com/openatv/enigma2/commit/14cbfa7b7c412722b600a13feac065a21340435d

"InfobarChannelSelection" keymap has no volumeUp and volumeDown

These two lines makes no sense.

popking159 commented 4 months ago

This is not I asked for . After assignment, each click make the action by one step , so I must do many repeated click to increase or decrease volume , If you can modify it by adding the flage "repeat" it will be enough. If not you can go for alternative solution My alternative solution is to add these 2 line , for you it makes no sense, for me it makes sense , if These to line present, I can modify keymap.xml to add another 2 lines that will do my request.

and the same for cross_right

All this because alot of users prefer to control volume by right and left , and control zap by up and down and service list by ok button .

Adding easy another control mode to many users is a good thing . Refards

jbleyel commented 4 months ago

This is not that easy because you are using hotkey's and the "ButtonSetupActions" have no repeat flag.

popking159 commented 4 months ago

This is not that easy because you are using hotkey's and the "ButtonSetupActions" have no repeat flag.

No problem, I will do the modifications on my image . I did it already and it is working .

jbleyel commented 4 months ago

You can try this:

Create a this file "/etc/enigma2/keymap_usermod.xml" with this content:

Warning!!!

The left / right buttons may no longer working for other things.

<keymap>

    <map context="GlobalActions">
        <key id="KEY_RIGHT" mapto="volumeUp" flags="mr" />
        <key id="KEY_LEFT" mapto="volumeDown" flags="mr" />
    </map>

</keymap>
popking159 commented 4 months ago

You can try this:

Create a this file "/etc/enigma2/keymap_usermod.xml" with this content:

Warning!!!

The left / right buttons may no longer working for other things.

<keymap>

  <map context="GlobalActions">
      <key id="KEY_RIGHT" mapto="volumeUp" flags="mr" />
      <key id="KEY_LEFT" mapto="volumeDown" flags="mr" />
  </map>

</keymap>

I will try , this method may be enough for me Thanks

popking159 commented 4 months ago

I modified it a little now it does what i want exactly but with adding the 2 non sense lines in InfoBarGenerics.py file `

<map context="InfobarChannelSelection">
    <key id="KEY_RIGHT" mapto="volumeUp" flags="mr" />
    <key id="KEY_LEFT" mapto="volumeDown" flags="mr" />
</map>

`

this keymap_usermod.xml is a good alternative to the main file " hotkey.xml" manual modification . NOW , i have to add keymap_usermod.xml to its path and do a manual modification for InfoBarGenerics.py file what i want now is to add the 2 non sense lines as they make sense to me . Regards