search

openatv / enigma2

openatv-gui
GNU General Public License v2.0
200 stars 317 forks source link

Button text missing on Skin Default #3379

Open ian10951 opened 2 months ago

ian10951 commented 2 months ago

This has been reported a number of times recently on various forums from people using various skins. My skin has the same issue too. It started after someone refactored some code a number of months ago.

To see the issue yourselves just boot the box into the Skin Default emergency skin and you will see all the coloured buttons are displayed but none have the text next to them stating what pressing a given button achieves. But as I said this issue is not limited to just the Skin Default skin, its present on quite a number of other skins too.

jbleyel commented 2 months ago

Please provide a screenshot of the affected screen. We can fix the default skin but not the other skins because that needs to be done by the skinner.

ian10951 commented 2 months ago

Its any screen that has coloured buttons, the text is always missing.

I've attached 2 random screens for you to see from the Skin Default, but as i said its all screens that have any coloured buttons displayed including the infobar. 1_0_19_4488_4088_233A_EEEE0000_0_0_0_20240711093052 1_0_19_4488_4088_233A_EEEE0000_0_0_0_20240711093116

ian10951 commented 2 months ago

Its the same when using the GraphicalInfobar too and the normal Graphical EPG. Its most annoying.

Wouldnt it be better to fix the code causing this rather than just fixing the default skin ? Then it would also fix many other 3rd party skins as well. Unfortunately, I do not know exactly which refactoring caused this issue to appear.

1_0_19_93_2_85_C00000_0_0_0_20240711094341

jbleyel commented 2 months ago

https://github.com/openatv/enigma2/commit/99294564b4fc8194d8abdc9d140783f8790bc98a

- Make all button definitions follow the standards by replacing Button() with StaticText().

jbleyel commented 2 months ago

All color buttons will be StaticText step by step.

ian10951 commented 2 months ago

Thanks for the fix.

However now I've updated to 7.4 stable I no longer have the dev level so it maybe a few days before I can report further on this. Hopefully though not to many and there will be a normal 7.4 image update available soon.

jbleyel commented 2 months ago

What you mean with fix? There is no fix. The change from Button to StaticText is from April 18 and already in the productive 7.4 image.

ian10951 commented 2 months ago

Oh ok

Well its not working then at least in older skins including the Skin Default as you can see from those screenshots I posted. And as I said a number of people on various forums are having the same issue.

jbleyel commented 2 months ago

You need to change the Skin. The color button text needs to be a source widget like in 90% of the screens.

ian10951 commented 2 months ago

Ok I will do that.

I at least am capable of doing that, but many other users are not. I dont understand why changes have to be made that break things that a lot of people who are just regular users can do nothing about. Everything worked perfectly before those changes so why fix something that isnt broken ?

Anyway Thank You for your suggestion and I at least will have my skin working properly again once I make these changes. However, that wont fix the default skin, that still needs fixing and I guess other users with this issue will just have to use another skin and get rid of their favoured skin because its now too old and no longer works with the later ATV images.

You have to remember many skins available on the ATV feeds that many people use are no longer maintained by the skins author, so users now have to user another skin entirely or put up with their existing skin no longer working correctly.

Perhaps its time to remove some of the skins on the feed that now dont function correctly after this and other recent updates.

jbleyel commented 2 months ago

I'm pretty sure that all the other distributions will do that too. The default skin needs some more fixes.

wedebe commented 1 month ago

Just my 2 cent here - shouldn't breaking, potentially breaking and significant / refactor changes be done on the development branch & version (7.5 as of now).

People stopped developing skins for the likes of Mozilla Thunderbird (mail client) 'cos of constant breaking changes and improvements. Granted, these changes are for the better in the long run, but at least provide a frozen/stable version. Furthermore, there are likely a number of skins no longer under development by their creators.

jbleyel commented 3 weeks ago

Just my 2 cent here - shouldn't breaking, potentially breaking and significant / refactor changes be done on the development branch & version (7.5 as of now).

People stopped developing skins for the likes of Mozilla Thunderbird (mail client) 'cos of constant breaking changes and improvements. Granted, these changes are for the better in the long run, but at least provide a frozen/stable version. Furthermore, there are likely a number of skins no longer under development by their creators.

I understand your point. But we do not differentiate between major and minor changes in enigma core. The major version updates are mostly because of oe changes.

We always try to update the code without skin changes but this is not always possible. And sometimes we just fix a very old bug in skins.

jbleyel commented 2 weeks ago

@ian10951 : Can we close this?

ian10951 commented 2 weeks ago

I guess so.

Its not been fixed though in the default skin, but at least now your aware of the issue.