openatv / enigma2

openatv-gui
GNU General Public License v2.0
200 stars 315 forks source link

Why is the default skin 720 only ? #3412

Open ian10951 opened 2 months ago

ian10951 commented 2 months ago

This means that if anyone loads a 1080 skin and maybe theres a screen missing, then it reverts to the default skin and everything is the wrong size.

Perhaps its time to update this skin with updates to the text for the colour buttons as thats missing as I've pointed out before and making it both 720 and 1080 compatble.

IanSav commented 2 months ago

A better solution is to add the resolution specifications to the default skin. This will trigger the auto resolution code in the skin.

jbleyel commented 2 months ago

Hi @ian10951 , if you find a skinner who can fix / maintain the default skin please let me know. I have no time for this.

Please note .. the default skin is only for boxes with no extra skin installed or as fallback if your main skin has not all the screens.

Default is probably not the correct name because it's mainly used as emergency / fallback skin.

ian10951 commented 2 months ago

Yes a thats exactly whats happening, Yesterday I converted my skin to 1080, however I do have a few screens missing as my skin is rather old and Ive been using the default skin as fallback. This was fine when my skin was still 720, but now its 1080 every screen I use the default skin to fallback to is now the incorrect size and very small.

jbleyel commented 2 months ago

The default skin is from 1900 and needs a complete refresh. But this is not that easy and needs a lot of time.

ian10951 commented 2 months ago

Ok,

Made me laugh that jbleyel, it was funny. lol

ian10951 commented 2 months ago

A better solution is to add the resolution specifications to the default skin. This will trigger the auto resolution code in the skin.

Would you be able to do this until the skin can be rewritten ?

Sadly I dont know any skinners , I only know of Kiddac, but I dont know him online personally.

kiddac commented 2 months ago

The problem is there is lots of code in the openatv solution that thinks everything is old school sd skins and everything then has to get scaled up with the 1.5 scale factor. . SD boxes are pretty much redundant now. There should be an option for SD and HD default skin. Metrix HD (which is actually SD unless you change the settings), also causes problems with other plugins due to confusion about what the actual screen size is..

I have a windows app that I wrote years ago that will scale up 720 skins. Its very simply to use.

https://www.linuxsat-support.com/thread/128786-enigma2-1080-skin-converter/

Enigma2SkinConverter-v1.06.zip

IanSav commented 2 months ago

OpenATV does not use simple scale factors. The scaling done by OpenATV is completely different from all other images. Scaling can be done dynamically and automatically on a screen by screen basis. Any screen can be scaled up or down to suit the resolution of the active skin.

The missing part for ian10951 is that the default/emergency skin has not been updated to use this new facility as it has historically been shared with other images. This is about to change as plans are in place for OpenATV to have its own dedicated default/emergency skin that will be included with the OpenATV image. This skin will offer automatically scalable default/emergency screens to back up any skin, in any resolution, that is missing those screens.

By the way, Metrix is a HD/FHD skin. The desire for skins to be FHD is also a matter of opinion. This is not the place to discuss the alternative views.

kiddac commented 2 months ago

By sd skin - I mean 1280 x 720, hd skin - I mean 1920 x 1080

Because that used to be the old way we referred to them whether you had an sd box or a hd box.

Yes I know nowadays technically speaking 1280 x 720 = hd 1920 x 1080 = fhd 2560 x 1440 = qhd 3840 x 2160 = 4k

kiddac commented 2 months ago

And maybe get rid of metrix skin altogether, The design is so 10 years ago, I don't know anyone that uses it in the UK. Maybe they do in Germany??? Just have one nice new modern default skin, that doesn't have all those unnecessary large icons.

jbleyel commented 2 months ago

I think you are wrong because Metrix is the most used skin of ATV and all clones of ATV and not only in Germany.

ian10951 commented 2 months ago

Kiddac is correct about Matrix in England.

Absolutely no one uses it that I know of, most find it ugly and very old fashioned. However as stated this might be different in Germany.

IanSav commented 2 months ago

What is the most popular skin for OpenATV in England?

Who is the skin author? Perhaps they would be interested in providing an OpenATV version.

ian10951 commented 2 months ago

Hard to say. I just know its not Matrix. Skins are a personal choice and many like myself adapt much older skins to run on modern images, simply because there are very few if any new ATV skins. My skin is an old adapted PLi-HD skin and I do know that Pli fullnight skin thats been taken over by Stein17 on the feeds is popular, mainly due to the fact that its one of the few ATV skins still updated.

IanSav commented 2 months ago

Do you want to have a look at OverlayHD and tell me what you think.

Yes it is a biased opinion but I would be interested to know how my skin compares to your expectations. It is going to get some updates soon to offer all the latest OpenATV skinning features. If OverlayHD is more to your liking then I would he happy to expand it to cover all the OpenATV screens and plugins that are not currently supported.

I am not a graphical artist so there are a number of screens with holder or missing images. Again, if there is interest in the skin hopefully I can find someone to help complete the images in a style like those images I have.

ian10951 commented 2 months ago

Doesnt make a difference to me to be honest as long as its there for other skins to fallback to if they have missing screens, so all possible screens would have to work in both 720 and 1080.

I think this is what 99% of users will use it for. I doubt many will use it as their main skin.

ian10951 commented 2 months ago

Quite a nice skin that. First time ive ever seen it. Personally I would have blended the infobar rather than having sharpe edges but hey thats just me. It is however just 720 so in its current state it wouldnt be suitable as the fallback/default skin for other skins to fallback to if they have missing screens, because the situation would be exactly as it is now with the existing default skin in the fact that if users were using a 1080 skin, everything would be tiny on any screens their skin had missing and therefore used your skin as fallback.

I'm back on my own skin again now because I have added significantly more information in my infobar such as VPN status, bandwidth traffic, HDD/USB space used, memory and CPU usage ect ect ect. But your does seem nice enough to be used for fallback screens for sure.

IanSav commented 2 months ago

When the default/emergency skin is rebuilt all the autoscaling code changes will be made so that it can and will offer replacement screens for any skin missing those screens.

As you say, the hard edge in OverlayHD is a design choice. Did you have a look at the configuration plugin?

ian10951 commented 2 months ago

Yes the plugin is a nice touch and the skin seems very variable when using the plugin.

It is one of the better skins I've seen. If I used it though I would have to add more info into the infobar, but again thats just me as I like a lot of info about if Exteplayer3 or Gstreamer is in use, VPN status and image information. But again thats just me, everyone is different lol.

ian10951 commented 2 months ago

This is my InfoBar, its how I like the info shown to me. But I do know its not to everyones taste. And as you can see its blended lol

5002_0_19_71_B_85_C00000_0_0_0_20240902151223

Same channel but this time from Sat rather than a stream 1_0_19_71_B_85_C00000_0_0_0_20240902151743

IanSav commented 2 months ago

You are used to that screen so I am sure you can pick out the information you want.

For me, I think there is too much information and it will be hard to read when you are sitting in a seat a few metres away from the screen. (That is one of the main reasons why OverlayHD is a HD (720p) skin.)

When I get leave from developing to spend time on OverlayHD I would be happy to take input and suggestion to increase its appeal. I doubt that I will ever get to the data density that you want but there other ways to skin that cat. For example adding another InfoBar screen that can provide more of the data you would like to see.

ian10951 commented 2 months ago

Sounds good.

But first things first, the default skin issues in ATV need to be addressed. I wish you luck in sorting it because skinning is very time consuming and can be very frustrating too.

IanSav commented 2 months ago

Yes, building skins is very time consuming. If you try to build them to have pixel perfect alignment then it is even more time consuming.

As I am now primarily a developer so I don't think I will be doing the work on the new default/emergency skin. I will be a contributor but probably not the main coder. We will see how the job allocations turn out. What I can say is that the new skin will be minimum on graphics and built for speed and simplicity. It will be fully functional and is intended to get the job done but will be minimalistic.

I am hoping that the concept designs are being organised soon and then we will start to flesh it out. As the skin is built all the embedded screens will be removed from the code into this skin. This will reduce the size of the code and provide a complete skin which other skinners can use as a sample of what is required together with some ideas on how to get the job done.

Part of my assigned work has been to write some skinner documentation to help skinners understand all the new and enhanced skinning options being made available to OpenATV skinners. The manual for the new ChannelSelection screen and skins has been written but is being proof read and reviewed before being published. Other manuals are also planned to be written.

ian10951 commented 2 months ago

Thats a marvelous idea.

I'm so tired of code being refactored and breaking things in my skin and then being clueless as to how to fix it and spending hours upon hours studying the refactored code so as to understand the new method used and then when I've got my head around it finally being able to fix my skin again. Its a real pain !

Having manuals containing information on refactored code and what it means to how skins need to change to work again will be invaluable. Not just for skiners but for hobbiests like myself too.

IanSav commented 2 months ago

If you are currently having issues maintaining your skin then you should reach out for help in either the forums or in Discord to see if others, including the developers, can help you out. The developer group is very busy but we may be able to help out if time permits.

The Metrix skin is often updated quite quickly to match the new code. OverlayHD is also updated fairly promptly as well. You may care to keep an eye on these skins to give you some hints and clues about how some of the new code works. I am working on updates for OverlayHD to switch from Python templates to the new XML based skin templates. I also am preparing the new skin to allow use of the new skinnable ChannelSelection screen. Unfortunately my development duties are trumping my skinning duties so I can't publish OverlayHD updates as often as I would like.

I also need to find time to publish my InfoBarTimers plugin that adds additional information the the standard InfoBar display. This plugin might give you some ideas on how to add more information to the standard InfoBar to get someof that extra information you would like to see.

IanSav commented 2 months ago

With regard to skin documentation, I suggest you keep an eye on the "doc" directory in the repository. That is where all the documentation is kept. This is where the new documentation will be added.

kiddac commented 2 months ago

When starting out with skinning in Enigma2, most people, including myself, turn to the default skin to figure out how to create a custom skin. Since there’s no definitive guide or "bible" for Enigma2 skinning, you typically begin by copying and tweaking someone else’s work until it all clicks. However, the problem is that the default skin isn’t given much attention or priority. Instead, all the focus is on the Metrix skin, which is far too complex to learn from. Metrix is a maze of templates within templates, and its customizability only adds to the confusion.

As Ian pointed out, when something breaks, skinners often refer to the image's default skin to troubleshoot and adjust their code. But if the default skin itself isn’t fully functional, it makes things even more challenging.

A default skin should be clean, simple, and include all the necessary elements. It should avoid large, unsightly icons and multiple layouts. More comments explaining what each widget line does and where to find its source on GitHub would also be helpful.

Skinning in 2024 is easier because design trends have moved towards simplicity and flat aesthetics. Glossy effects are unnecessary, shadows can be skipped, and colour palettes can be limited. Subtle gradients work well, but strong gradients and unnecessary graphics should be avoided.

jbleyel commented 2 months ago

We have already started a skin documentation. You can help with review if you like.

kiddac commented 2 months ago

I am trying to retire. My days of coding for enigma2 are coming to an end. Very soon. It is someone else's turn to take up the challenge. Which is why I am trying to get everything fixed before I disappear. :)

jbleyel commented 2 months ago

I am trying to retire. My days of coding for enigma2 are coming to an end. Very soon. It is someone else's turn to take up the challenge. Which is why I am trying to get everything fixed before I disappear. :)

Unfortunately another one less, but you may enjoy your retirement. Let's see if someone can keep your code up to date and fix any bugs.