search

openatv / enigma2

openatv-gui
GNU General Public License v2.0
200 stars 317 forks source link

CronTimer.py vkeyicon #998

Closed kiddac closed 5 years ago

kiddac commented 6 years ago

Can you please add in self["VKeyIcon"] = Boolean(False)

to the class CronTimersConfig

As it's calling setup screen it throws an error without it,

Thank you.

kiddac commented 5 years ago

This problem still exists.

Code without self["VKeyIcon"] = Boolean(False)

image

Code with from Components.Sources.Boolean import Boolean class CronTimersConfig(Screen, ConfigListScreen): def init(self, session): ... self["VKeyIcon"] = Boolean(False)

image

atvcaptain commented 5 years ago

see https://github.com/openatv/enigma2/commit/48d8b56fafd1dc0e4945e74ddea33e66a586b9b6

kiddac commented 5 years ago

Is this actually a problem with setup.py or just old code in Infopanel Plugin. I am creating a new skin at the moment, so I am noticing these errors.

This is also true for /lib/python/Plugins/Extensions/Infopanel/plugin.py class ShowSoftcamPanelExtensions(ConfigListScreen, Screen):

19:41:53.6275 { } Plugins/Extensions/Infopanel/plugin.py:451 ok [INFO-Panel] MenuItem: Softcam-Panel Setup 19:41:53.6289 { } Plugins/Extensions/Infopanel/CamCheck.py:21 CamCheckStop CamCheck not running, so no need to stop it !! 19:41:53.6304 { } skin.py:1354 readSkin [SKIN] processing screen Setup: 19:41:53.6460 { E } skin.py:1224 process_widget [Skin] Error: Source 'VKeyIcon' was not found in screen 'Setup'! 19:41:53.6464 { E } skin.py:1359 readSkin [SKIN] SKIN ERROR in Setup: 'NoneType' object has no attribute 'downstream_elements' 19:41:53.6705 { W } Components/GUISkin.py:35 createGUIScreen warning, skin is missing element labelExitsave in <class 'Plugins.Extensions.Infopanel.plugin.ShowSoftcamPanelExtensions'>

kiddac commented 5 years ago

In my skin designs I always get around this problem by putting the vkeyicon widget last in that screen. That way when it fails it doesn't block the other elements. I notice other skins like default skin don't do this though. So this problem must have been around for a while and gone unnoticed.