openatx / adbutils

pure python adb library for google adb service.
MIT License
728 stars 173 forks source link

Merge `adbutils_async` as an Asynchronous Version of `adbutils`? #132

Open touxiaoling opened 1 month ago

touxiaoling commented 1 month ago

Hello,

I have rewritten an asynchronous version of adbutils called adbutils_async, which you can find here: https://github.com/touxiaoling/adbutils_async. I have been using it with real devices for the past two months. However, this version only supports Python 3.10+.

I would like to inquire if you would be interested in helping me merge adbutils_async into the openatx/adbutils repository.

Here are some questions:

  1. Compatibility: This version currently only supports Python 3.10+. I have only tested it with Python 3.12. However, I don't have much experience in adding compatibility for other versions. Could you provide some suggestions on this?
  2. Testing: The test cases are not comprehensive. Should I complete and improve the asynchronous test cases before you consider merging it?

Please let me know if there are any additional requirements or modifications needed. I am open to collaborating and making necessary adjustments to ensure compatibility and maintainability.

Thank you for your time and consideration.

Best regards, touxiaoling

codeskyblue commented 1 month ago

Wow it is amazing to hear that. Tests is required for new functions. The lib httpx can be referenced for sync and async how does it exists both in one lib.

codeskyblue commented 1 month ago

Use miniconda can create Python 3.8 environment