search

openatx / adbutils

pure python adb library for google adb service.
MIT License
736 stars 173 forks source link

no re.Pattern in re module #87

Closed ncu1121zhb closed 1 year ago

ncu1121zhb commented 1 year ago

Hi, team

Please check the following code in adbutils_device.py: def logcat(self, file: StrOrPathLike = None, clear: bool = False, re_filter: typing.Union[str, re.Pattern] = None, command: str = "logcat -v time") -> StopEvent:

There is no re.Pattern in re module, here re pattern is needed, so pls consider to use re.compile instead, since re.compile(pattern, flag=0) return a Pattern object. I hope my comment would be read soon, and look forward to hearing from you. Thanks

PythonTryHard commented 1 year ago

Seems like a duplicate of #82