openaustralia / australian_local_councillors_popolo

Popolo data for Local Councillors in Australia
Other
6 stars 6 forks source link

Created csv file of local councillor based on state in data folder #124

Closed hisayohorie closed 7 years ago

hisayohorie commented 7 years ago

This is a part of #95

I created a folder named data, and each state have folder that contains local_councillors.csv file

              --data-|
                     |--ACT----act_local_councillors.csv
                     |--NSW----nsw_local_councillors.csv
                     |--NT------nt_local_councillors.csv
                     |--QLD----qld_local_councillors.csv
                     |--SA-----sa_local_councillors.csv
                     |--TAS----tas_local_councillors.csv
                     |--VIC-----vic_local_councillors.csv
                     |--WA-----wa_local_councillors.csv

In a few csv files, there were special charactors that keep aborting rake tasks, such as å and û. I changed them into a and u, as it is unnecessary troubles for contributors. We can update our councillor contribution instruction on PlanningAlerts accordingly.

equivalentideas commented 7 years ago

In a few csv files, there were special charactors that keep aborting rake tasks, such as å and û.

It's interesting that this wasn't a problem before.

I changed them into a and u, as it is unnecessary troubles for contributors.

Most people don't know how to add these characters, but they are important to some people (like my partner :D ), and if they go to the trouble of spelling their name with the correct characters, I think we should support them and show the name as it's intended. If this wasn't a problem before, we should make sure it's not a problem with this PR either.

What do you think about that perspective @hisayohorie ?

equivalentideas commented 7 years ago

What do you think about that perspective @hisayohorie ?

I just had a bit more of a think about this and realised that this step is just about getting the files into the repo. PR #125 is about changing the process to use these files rather than the Google docs.

So it actually doesn't matter at this stage that the rake tasks don't work.

I think the best approach is to revert them to the original characters, and then deal with this problem as part of the other PR. We can add tests at that stage as well to be really deliberate with this issue.

How does that sound?

equivalentideas commented 7 years ago

Also, just remembered over on https://github.com/openaustralia/planningalerts/issues/1203#issuecomment-330197776 :

Make sure all the current contributions in the Google sheet are imported to the Popolo and into PlanningAlerts. If we're not working from a clean slate I can imaging this getting really confusing.

So before merging this we should make sure all the changes from the google sheet have been incorporated, e.g. running the current rake tasks should produce no changes.

There's unmerged changes to:

hisayohorie commented 7 years ago

@equivalentideas I get that special charactors are important to reflect who they are! I think the issue was excel and not rake had a bug to convert special charactors, because I was using exel to open the csv file. I'll change back the special charactors.

equivalentideas commented 7 years ago

@hisayohorie I've assigned this one to me to finish off, cause a new contribution has come in and I'd like to try our new system :D