Updated the rake task to fetch local csv instead of google spread sheet

openaustralia / australian_local_councillors_popolo

Popolo data for Local Councillors in Australia

Other

6 stars 6 forks source link

Updated the rake task to fetch local csv instead of google spread sheet #125

Closed hisayohorie closed 7 years ago

hisayohorie commented 7 years ago

PR #124 should be merged before this PR

This is a part of #95.

In this PR, I updated rake task to fetch councillor data from local csv files in data folder instead of google spread sheet. Rake task will abort without csv files in data folder so please merge#124 before this. As I mentioned in #124, In a few csv files, there were special charactors that keep aborting rake tasks, such as å and û. I changed them into a and u, as it is unnecessary troubles for contributors.

equivalentideas commented 7 years ago

@hisayohorie I've just merged master in here and also did a little refactor to extract a Class from the rake file. This will make it clearer to create tests when we're ready—maybe we are now? not sure.

equivalentideas commented 7 years ago

Merged! Thanks @hisayohorie . I added to the docs to explain this new system too 😄

equivalentideas commented 7 years ago

Since moving the popolo data files with this we need to update our data source urls in:

[x] https://github.com/openaustralia/australian_local_councillors_images/issues/6
[x] https://github.com/openaustralia/planningalerts/issues/1254
[x] Writeit (I've added new data sources, test everything works after updating the other bits) — I'm going to keep an eye on this, but because of the robust way we connect councillors with comments in PlanningAlerts this shouldn't be a problem.