openaustralia / australian_local_councillors_popolo

Popolo data for Local Councillors in Australia
Other
6 stars 6 forks source link

Also store copies of the CSVs in this repo for backup purposes #95

Closed henare closed 7 years ago

henare commented 8 years ago

While importing some contributions I just noticed that it was quite hard to spot an unintentional error and fix it using the Sheets revision history. Maybe storing copies of the CSVs we download would help?

equivalentideas commented 7 years ago

As part of https://github.com/openaustralia/planningalerts/issues/1203#issuecomment-330197776 @hisayohorie and I agreed we need to get the CSV's into the repo. Read more up on that issue about the process we're imaging.

noticed that it was quite hard to spot an unintentional error and fix it using the Sheets revision histor

This should be much easier with git diffs and the ability to git checkout to a specific clean slate.

So we're imaging following the pattern used by EveryPolitician of having a folder for each data folder, a folder for each jurisdiction, and then the csv and json in there. See https://github.com/everypolitician/everypolitician-data/tree/master/data/Australia/Representatives

So we're imaging a directory structure like:

Steps (separate PRs):

  1. [x] download the CSV files, name them appropriately and put them into the repo (done in https://github.com/openaustralia/australian_local_councillors_popolo/pull/124)

  2. [x] add the directory structure and adapt the rake task to work with it

  3. [x] adapt the rake file to target the local CSV file rather than the Google Doc

    • [x] update the docs to explain that you need to edit these files now not the Google Sheet
equivalentideas commented 7 years ago

I've assigned this to you @hisayohorie post any questions or anything here 😄

equivalentideas commented 7 years ago

@hisayohorie is doing steps 1. " add the directory structure and adapt the rake task to work with it" and 3. "adapt the rake file to target the local CSV file rather than the Google Doc" in one go in #125

equivalentideas commented 7 years ago

This is now done in #125