openaustralia / jacaranda

a watchful tree and slack messenger to keep you informed of the use of your civic tech projects, like PlanningAlerts and Right To Know
https://morph.io/openaustralia/jacaranda
0 stars 1 forks source link

Refactor to improve code readability and re-use #4

Closed auxesis closed 7 years ago

auxesis commented 7 years ago
equivalentideas commented 7 years ago

Thanks so much for this big contribution @auxesis This will make this project much more reusable ❤️

Would you mind resolving the merge conflict here and then assigning back to me to merge?

equivalentideas commented 7 years ago

@auxesis there's a bit of stuff here that could be simplified by using more standard rspec conventions. I'd be happy to merge this and refactor as we go, or to make those change before merging too. What would you prefer?

This is a great contribution @auxesis 💯

auxesis commented 7 years ago

@equivalentideas my preference would be to merge it, and clean up the tests in #5.

5:

equivalentideas commented 7 years ago

my preference would be to merge it

Sounds good to me :shipit:

equivalentideas commented 7 years ago

@auxesis just ping me when that merge conflict is resolved and I'll merge it 👍

auxesis commented 7 years ago

@equivalentideas merge conflict fixed ✅

equivalentideas commented 7 years ago

:shipit: 🕶