openaustralia / morph

Take the hassle out of web scraping
https://morph.io
GNU Affero General Public License v3.0
461 stars 74 forks source link

Small test fixes after updating buildstep #1047

Closed mlandauer closed 8 years ago

mlandauer commented 8 years ago

This PR should only get merged at the same time as https://github.com/openaustralia/buildstep/pull/1

mlandauer commented 8 years ago

Note that the tests aren't expected to pass until the openaustralia/buildstep image has been updated from the PR https://github.com/openaustralia/buildstep/pull/1

mlandauer commented 8 years ago

To clarify comment ⬆️ the tests on travis-ci won't pass until the openaustralia/buildstep changes have been merged into master which will cause the openaustralia/buildstep image that is downloaded by travis to change.

For running the tests locally on this branch it should work fine as you long as your local image openaustralia/buildstep has been updated

mlandauer commented 8 years ago

Just pushed a small change to this branch (a merge from master actually) that should make the tests a little bit more reliable. @henare let's see if that makes a difference

henare commented 8 years ago

My test suite is passing. Assigning back to you for merge and deploy.