Limit log lines in process

openaustralia / morph

Take the hassle out of web scraping

https://morph.io

GNU Affero General Public License v3.0

461 stars 74 forks source link

Limit log lines in process #1081

Closed mlandauer closed 8 years ago

mlandauer commented 8 years ago

Much better solution to #919. This limits the log output at the process level by running the scraper within a wrapper script. This ensures that a scraper infinitely producing log lines will not fill up the log file within the docker container.

henare commented 8 years ago

@mlandauer I'm supposed to be away today and not back until Tuesday so I can't do a proper code review right now. It's almost certainly more important to get this deployed and socialised so I'll assign it back to you. You could also ask @equivalentideas to double-check it and do a quick review if you think it needs it but I'll leave that up to you.

mlandauer commented 8 years ago

Okay cool. Thanks @henare. I'll just go ahead and merge and deploy it so that we can see if I've broken anything :-)