search

openaustralia / morph

Take the hassle out of web scraping
https://morph.io
GNU Affero General Public License v3.0
461 stars 74 forks source link

[WIP] Make backups easier to understand. #1114

Closed auxesis closed 6 years ago

auxesis commented 7 years ago

This PR is a Work in Progress. Please don't merge until I say I think it's in an OK state.

I've refactored the backup script into functions.

The intention is to make the logic easier to follow, so the operator doesn't need to know all the details of how the backups are performed.

Currently the only logic change is the number of backups to retain (was previously 5, now set to 1, due to disk space problems per #1104)

equivalentideas commented 7 years ago

@auxesis I've raised the one query I had, but overall the named functions seem like a useful extraction 👍 I can understand what's going on here :)

mlandauer commented 6 years ago

As there hasn't been any activity on this WIP PR in a while I'm closing this