openaustralia / morph

Take the hassle out of web scraping
https://morph.io
GNU Affero General Public License v3.0
461 stars 74 forks source link

Make user menu show up on small screens. Fix to #918. #1143

Closed EkaterinaSemenova closed 7 years ago

EkaterinaSemenova commented 7 years ago

"hidden-sm" class on user menu seems to be preventing it from being displayed on small screens. This pull request removes "hidden-sm" class from it and thus fixes #918. Here is video illustrating fix https://goo.gl/DmWWUx Example of user menu with fix applied: user

equivalentideas commented 7 years ago

"hidden-sm" class on user menu seems to be preventing it from being displayed on small screens. This pull request removes "hidden-sm" class from it and thus fixes #918.

Thanks @EkaterinaSemenova That does seem to work, but from your video, it also makes the menu open by default on small screens. Or at least it opens automatically when you reduce screen size. That's a problem because it's unexpected, and also covers much of the screen without the user asking it to. If that's the case, we should fix this so it only makes the change requested in the issue.

I've added a bit more info to the issue, I wasn't even quite sure what it was about :) https://github.com/openaustralia/morph/issues/918#issuecomment-292368933

Also, great work including the video :D That makes it so much easier to review ❤️

EkaterinaSemenova commented 7 years ago

Hi @equivalentideas, thanks for your comment. On my video menu is open on small screens just because I opened it before capture of the video. In fact, menu just "remembers" its last state. I hope my new video will clarify everything https://goo.gl/Zlqr73 The only reason why user name disappears from menu is "hidden-sm" class on it (it makes it hide on small screens) and my PR removes it.

equivalentideas commented 7 years ago

I hope my new video will clarify everything

Perfectly :D Sorry about the confusion and also thanks for these great videos making it super clear.

Nice work @EkaterinaSemenova 👍