search

openaustralia / righttoknow

Theme for, and issues specific to, Right To Know.
https://www.righttoknow.org.au/
MIT License
21 stars 14 forks source link

You can't access old requests using the pagination links on the View Requests page #690

Open equivalentideas opened 7 years ago

equivalentideas commented 7 years ago

Reported by a star community member:

I have been looking to older pages in Right to Know. Now I am looking at page 20 https://www.righttoknow.org.au/list/all?page=20

But I cannot advance. "Next" is inoperational and there is no number "21" in the list. Also when I change the request in the URL to https://www.righttoknow.org.au/list/all?page=22 (this is a 2 page advance), I receive a page that explains this page cannot be found.

I think that this is a recent change of function and that it was once recently possible to look at the older pages, even the very oldest page. This looks like a bug because I think it is useful to look at pages earlier than January 2017 (which is now page 20).

crowbot commented 7 years ago

Upstream ticket https://github.com/mysociety/alaveteli/issues/2137

handelaar commented 7 years ago

It strikes me that this fix was rather WDTK-xapian-index-size specific and perhaps MAX_RESULTS belongs in a config setting with default=500, instead of being hard-coded?

https://github.com/mysociety/alaveteli/commit/a1655ba57f94f2a0058dc03cf1da67b7a763eb49