Rename fixture files to allow git clone on Windows

openaustralia / theyvoteforyou

Making parliamentary voting information accessible, understandable, and easy to use so that you can hold your elected representatives to account.

https://theyvoteforyou.org.au/

Other

136 stars 30 forks source link

Closed cofiem closed 2 years ago

cofiem commented 2 years ago

The character '?' is not allowed in paths on Windows. This means this repo as it is cannot be cloned on Windows.

Git gives this error: error: invalid path 'spec/fixtures/static_pages/search?query=0000.html'.

This PR renames the files to replace '?' with '__'. It also makes the same replacement when loading the files for tests.

There are also some string replacements of "\r\n" with "\n" to ignore newline differences when running the tests on Windows.

mlandauer commented 2 years ago

Looks good to me. Thanks @cofiem! 🎉