search

openaustralia / theyvoteforyou

Making parliamentary voting information accessible, understandable, and easy to use so that you can hold your elected representatives to account.
https://theyvoteforyou.org.au/
Other
136 stars 30 forks source link

Network failure causes test failure #194

Closed DanielKinsman closed 10 years ago

DanielKinsman commented 10 years ago

One test fails if the network is down, due to a postcode lookup from openaustralia.org.

Two solutions:

  1. nothing to see here, we're in 2014 - internet is required for running tests
  2. mock it
henare commented 10 years ago

I'd normally use VCR for Ruby projects but this won't work with PHP too.

I vote internet is required until we get rid of the PHP stuff.

DanielKinsman commented 10 years ago

Sounds like a plan.