search

openaustralia / yinyo

A wonderfully simple API driven service to reliably execute many long running scrapers in a super scaleable way
https://yinyo.io
Apache License 2.0
6 stars 1 forks source link

Explore Github Actions for CI and build #114

Closed jamezpolley closed 4 years ago

jamezpolley commented 4 years ago

Possible partial implementation of #97

jamezpolley commented 4 years ago

@mlandauer Did you know Github has an inbuilt workflow feature now?

It looks like we have ~10k minutes/month of free usage because of our account type.

mlandauer commented 4 years ago

i'm definitely happy to give github actions a try. :-)

@jamezpolley do you want me to look at this? I see you've asked me to review this but it's not yet working as the tests are failing so I'm a little confused.

jamezpolley commented 4 years ago

i'm definitely happy to give github actions a try. :-)

@jamezpolley do you want me to look at this? I see you've asked me to review this but it's not yet working as the tests are failing so I'm a little confused.

Was just wanting to get initial feedback from you about whether this was worth going ahead with.

jamezpolley commented 4 years ago

I've now sorted out the last issue by explicitly setting $GOPATH as suggested in https://github.com/actions/setup-go/issues/14#issuecomment-563273583 so that we can run the yinyo binary in the test

mlandauer commented 4 years ago

thank you @jamezpolley!