Direct the installer to the required Helm version

openaustralia / yinyo

A wonderfully simple API driven service to reliably execute many long running scrapers in a super scaleable way

https://yinyo.io

Apache License 2.0

6 stars 1 forks source link

Direct the installer to the required Helm version #158

Closed jamezpolley closed 4 years ago

jamezpolley commented 4 years ago

Fixes #157

jamezpolley commented 4 years ago

I note there's a script to automate this. Maybe we can put this in the makefile instead?

github-actions[bot] commented 4 years ago

Pull Request Test Coverage Report for Build 0245bd463-PR-158

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.108%

Totals
Change from base Build db3226e53:	0.0%
Covered Lines:	804
Relevant Lines:	1115

💛 - Coveralls

jamezpolley commented 4 years ago

I note there's a script to automate this. Maybe we can put this in the makefile instead?

On second thoughts, I think not.

If the installer already had an older version of Helm installed and needed that version, a surprise upgrade would be upsetting; and they may well skip a make helm step because they know they already have it.

Probably better to leave this is a documented requirement and let the installer make an informed choice

mlandauer commented 4 years ago

Probably better to leave this is a documented requirement and let the installer make an informed choice

Yup. I agree!

mlandauer commented 4 years ago

Thanks!