search

openaustralia / yinyo

A wonderfully simple API driven service to reliably execute many long running scrapers in a super scaleable way
https://yinyo.io
Apache License 2.0
6 stars 1 forks source link

Convert client.sh bash script to golang #68

Closed mlandauer closed 4 years ago

mlandauer commented 4 years ago

With this we can easily do much better error checking which would be super useful.

jamezpolley commented 4 years ago

At the moment, having client.sh in bash makes it quite portable. For someone setting up a dev environment, this is simple to use. It's true that it doesn't have great error checking, but imo that's balanced by being simple to use on any platform.

I can definitely see uses for having the client doing better error checking. I'm wondering if it's possible to still have something that's simple and cross-platform for people setting up a dev environment though, without needing them to install and compile the binary.

thinks Actually, I think I have a good idea of how this works, based on what I've seen other things like terraform and kustomise and minikube do - have CI builds for the various platforms, and have our makefile grab the correct binary from Github based on detecting the platform it's on.

So... I think this comment amounts to me thinking aloud with nothing particular to do.