openaustralia / yinyo

A wonderfully simple API driven service to reliably execute many long running scrapers in a super scaleable way
https://yinyo.io
Apache License 2.0
6 stars 1 forks source link

Make more use of Make throughout the bootstrap instructions #69

Closed jamezpolley closed 4 years ago

jamezpolley commented 4 years ago

I feel like this simplifies the initial bootstrap a bit - it lets me get up and running quickly without too much copy/paste or fiddling, but the exact commands are still easy to read in the Makefile.

jamezpolley commented 4 years ago

@mlandauer Do you want me to split this into two changes - one that's just the Make changes and one for the rest of the formatting?

mlandauer commented 4 years ago

@mlandauer Do you want me to split this into two changes - one that's just the Make changes and one for the rest of the formatting?

Yes please. Rule of thumb is each commit should be an atomic change that fits together. I'm happy with these changes being bundled into the same PR but they definitely shouldn't be in a single commit. There's at least separate commits for:

But before you put effort into doing that let me add some comments to your existing commit

jamezpolley commented 4 years ago

@mlandauer I think this is ready to go

mlandauer commented 4 years ago

Thanks @jamezpolley!