search

openaustralia / yinyo

A wonderfully simple API driven service to reliably execute many long running scrapers in a super scaleable way
https://yinyo.io
Apache License 2.0
6 stars 1 forks source link

Set $PATH to include the $GOPATH #84

Closed jamezpolley closed 4 years ago

jamezpolley commented 4 years ago

One possible fix for #83

Downside of this approach is that it slightly obscures from the user what they would need to do if they want to set $GOPATH themselves.

Upside is that it means that someone who doesn't care about developing go and just wants to get a test environment up and running can just "make test".

But.. if they are going to need to set $PATH in order to run clay by hand later, maybe it'd be better to document doing that.

mlandauer commented 4 years ago

My understanding, and this is based on me being a relatively new go developer, is that it's "normal" to set the $GOPATH and include $GOPATH/bin in your $PATH. I thought that's just a normal thing that all go developers do all the time for all projects. So, would it instead be sensible to include a quick sentence to that effect in the README?

jamezpolley commented 4 years ago

Based on discussions on skype - I was doing this thinking of people who aren't used to developing with Go. The README is targeted at people who are used to developing in Go and want to hack on the go code, so this isn't needed at this point.