openaustralia / yinyo

A wonderfully simple API driven service to reliably execute many long running scrapers in a super scaleable way
https://yinyo.io
Apache License 2.0
6 stars 1 forks source link

Add CI for unit tests / coverage testing #97

Closed mlandauer closed 4 years ago

mlandauer commented 4 years ago
jamezpolley commented 4 years ago

I've written up a proposal which may make this easier in #99. I've partially implemented the proposal from #99 in #100.

Edit: Nope, I don't think #99 makes this any easier.

mlandauer commented 4 years ago

@jamezpolley what's the state of this now? I'm figuring the CI bit is done, with github actions? Do we get notifications if the build fails? Also, is there coverage testing?

jamezpolley commented 4 years ago

127 expands the CI to add a lint check; coverage testing with coveralls; and a badge to show the current CI status as well.

I'm leaving that for you to merge as the lint check is currently failing. I don't know if you'd prefer to merge that and then fix the lint errors, or if you want to fix the lint errors in the branch before it merges.

jamezpolley commented 4 years ago

Notifications are already going to slack (eg, https://oaf.slack.com/archives/C2XD5LDN1/p1577158705005500) and I'm getting emails (I've shared one with you in Front)

jamezpolley commented 4 years ago

@mlandauer Assigning back to you as I'm waiting for your feedback in #127

jamezpolley commented 4 years ago

This seems to be complete.