search

openbakery / gradle-xcodePlugin

gradle plugin for building Xcode Projects for iOS, watchOS, macOS or tvOS
Apache License 2.0
457 stars 127 forks source link

[WIP] tvOS complete support #383

Open elsassph opened 6 years ago

elsassph commented 6 years ago
renep commented 6 years ago

I'm always very glad when someone adds a feature to the plugin and send me a pull request. But I'm a big fan of unit tests. If I had found test that verifies the change, I would have just have pressed the merge pull request button. So if you can add some tests that would be great. Otherwise I have to look into this myself. You find plenty of unit test in the project. I use the spockframework now for tests and the test classes have the suffix Specification. The classes with the suffix Test are normal unit tests. Adding tests for your change should not be that hard with spock, but if you prefer normal junit tests it's fine with me. 😉

elsassph commented 6 years ago

It's still very early investigation (having some weird issues now); we have to validate it and add tests for sure.

elsassph commented 6 years ago

Added a couple tests, and I'll ask for help to add more, but so far so good: running on simulator, build/archive/package with inhouse certificate :)

renep commented 6 years ago

Is this still WIP or is it ready to merge?

shoebox commented 6 years ago

@renep We are still working on it. I did a heavy refactoring around the archiving and packaging task, without breaking anything in the existing configuration here: https://github.com/massiveinteractive/gradle-xcodePlugin/pull/4/files

When it's merged we can move forward on that PR.

phatblat commented 6 years ago

😲 wow, this is a big PR

renep commented 6 years ago

Yes it is a big pull request. I also think it would make sense to make a web meeting before (or during) the merge of this pull request, so that you can enlighten me of the changes.

renep commented 4 years ago

Hmm... I don't know what to do with this pull request. @shoebox are you still interested in merging this pull request? If so than we should get in touch so that you can enlighten me about the changes.