search

openbakery / gradle-xcodePlugin

gradle plugin for building Xcode Projects for iOS, watchOS, macOS or tvOS
Apache License 2.0
457 stars 127 forks source link

Fixes packaging for non-fat binaries #403

Closed fonkadelic closed 5 years ago

fonkadelic commented 5 years ago

Since #402 has been merged, the packaging task is broken if the app has only one supported architecture. This is the case, if the deployment target of the app is >= iOS 11.0. This happens, because the output of lipo contains trailing spaces and does not include are:, so the parsing of the output would produce an array that included an empty string.

This PR updates how the results of lipo are parsed to handle this edge case. Additionally, the tests have been update to be more strict and catch edge cases like this.

renep commented 5 years ago

Test Build Version 0.15.4.develop.145 is available with the merge ;-)