search

openbao / openbao-helm

Helm chart to install OpenBao and other associated components.
Mozilla Public License 2.0
17 stars 8 forks source link

Remove templating from values.yaml #10

Open jessebot opened 6 months ago

jessebot commented 6 months ago

Templating should only be done in files under the charts/openbao/templates directory. The reason for this is that some users use third party templating tools, as Argo CD for gitops, which will be applying their own go-templating and it can cause conflicts and errors.

Here's an example of some values that should still be in the values.yaml as an example, but commented out by default:

https://github.com/openbao/openbao-helm/blob/b59b6e55bb124e6486f861feeb15c2428096634b/charts/openbao/values.yaml#L303-L304

We can still draw up some docs to explain to users how to use the affinity features of this chart and place them in the README or our official doc site, but defaults should always be template free.

cipherboy commented 3 months ago

I was curious where this templating comes from; is Kubernetes doing the templating or is that something within OpenBao?

jessebot commented 2 months ago

No problem :) This is all gotemplating from helm, separate from OpenBao itself, but it should be live in the templates dir instead of the values.yaml.