search

openbao / openbao-helm

Helm chart to install OpenBao and other associated components.
Mozilla Public License 2.0
7 stars 3 forks source link

Remove Hashicorp and Vault References #6

Open naphelps opened 1 month ago

naphelps commented 1 month ago

Change references as needed from Hashicorp Vault to OpenBao. Remove as needed Enterprise references.

jessebot commented 1 month ago

Should we also do the copyright notices? See https://github.com/openbao/openbao-helm/discussions/4

jessebot commented 1 month ago

Thanks for your reply in the discussion :)

Updates for this issue specifically, so others are in the know:

After #7 was merged, @naphelps took care of a lot of it (thank you 🙏 ). We still have a number of references to vault specifically in the _helpers.tpl template though. This is important, because typically in helm charts, named templated should reference the application you're deploying, as you can also reference downstream sub-chart templates, so if someone includes our openbao helm chart in their larger stack helm chart, it's important that they can consistantly reference for instance, the openbao.fullname template, which is useful for referencing various resources. Example:

https://github.com/openbao/openbao-helm/blob/b59b6e55bb124e6486f861feeb15c2428096634b/charts/openbao/templates/_helpers.tpl#L12-L23

Since these are all named templates, we'll also need to update locations that reference them, such as:

https://github.com/openbao/openbao-helm/blob/b59b6e55bb124e6486f861feeb15c2428096634b/charts/openbao/templates/tests/server-test.yaml#L12

I will take care of some of this while tending to #9, but we'll assess again after that. Other than that, we just need to finish up #3 and we should be golden on this issue :)

jessebot commented 1 month ago

I got the bulk of this in #11, but I missed a couple of important bits that I'll address in just a bit.