Open DivineThreepwood opened 4 years ago
test still succeeded because the unit test only test the affected devices and never the cancellation of impacted actions. I wrote a unit test testTestIntermediaryActionCancellationOnSceneDeactivation
in SceneRemoteTest
and reproduced the issue. Found already one bug in the SceneControllerImpl where an outdated action description was returned instead the new one with an updated impact action list. Therefore, the scenes where not able to cancel their impact. However, the test is still failing when all test of the test class are performed at once. In this case the impacted action are again not properly canceled. So issue still not fully solved.
Bug can be reproduced when an scene is activated which for example changes the color of an entire room to red via the location unit. The lights keep the red color even when the scene is deactivated. Because the scene is not active the actions are not auto extended and canceled after the validation timeout occurs.
It seems like intermediary actions do not cancel their caused actions, therefore please validate: