openbaton / NFVO

Repository containing the source code of the NFVO
Apache License 2.0
61 stars 52 forks source link

downloading NSD/VNFD from marketplace should not be allowed while using unsupported VIM plugins #121

Closed gc4rella closed 7 years ago

gc4rella commented 7 years ago

Clicking download NSD from marketplace while having a PoP registered using a non openstack plugin (for instance test), generates an error displayed on the dashboard as:

An error occured and could not be handled properly, please, report to us and we will fix it as soon as possible

on the NFVO logs:

`2017-03-28 11:18:52.377 ERROR 14 --- [http-nio-8080-exec-9] o.a.c.c.C.[.[.[/].[dispatcherServlet] : Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is java.lang.UnsupportedOperationException] with root cause

java.lang.UnsupportedOperationException: null at org.openbaton.vim_impl.vim.TestVIM.add(TestVIM.java:117) at org.openbaton.nfvo.core.api.VNFPackageManagement.handleImage(VNFPackageManagement.java:524) at org.openbaton.nfvo.core.api.VNFPackageManagement.onboard(VNFPackageManagement.java:179)`

Therefore, download from marketplace should be allowed only for VIM supporting this functionality.

lorenzotomasini commented 7 years ago

Problem here is that the VNFPackage metadata is not containing the "vim_types". so the NFVO cannot check if it is possible to add an image.

@gc4rella Should i put this field mandatory?

lorenzotomasini commented 7 years ago

screen shot 2017-04-06 at 12 07 54