search

openbaton / NFVO

Repository containing the source code of the NFVO
Apache License 2.0
61 stars 53 forks source link

Rethink delete VNFD from NSD method #172

Closed ThomasBri closed 6 years ago

ThomasBri commented 7 years ago

Currently, the deleteVnfDescriptor(String idNsd, String idVnfd, String projectId) method in the NetworkServiceDescriptorManagement class is not working. You cannot delete the VNFD because the NSD is still onboarded and if you delete the NSD first, it throws a NullPointerException.

This method is probably a leftover from the time when the VNFDs did not have their own management class and maybe it is better to alter the behavior to e.g. just removing the VNFD from the NSD but keeping it stored in Open Baton, in this way updating the NSD.

ThomasBri commented 7 years ago

Actually the whole /api/v1/ns-descriptors/<nsd_id>/<subcomponent> api path is buggy and should be reviewed.

marcellom commented 6 years ago

This https://github.com/openbaton/NFVO/pull/239 allows to delete a VNFD from a NSD. The VNFD is then removed from the NFVO. This issue is also related to https://github.com/openbaton/NFVO/issues/197.

marcellom commented 6 years ago

https://github.com/openbaton/NFVO/pull/239 has been merged, I close this issue.