search

openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
138 stars 50 forks source link

consider bluebird for Promise and enable developer warnings #112

Closed baffo32 closed 8 years ago

baffo32 commented 8 years ago

Using bluebird may create more robust code: http://bluebirdjs.com/docs/features.html#debuggability-and-error-handling

baffo32 commented 8 years ago

bluebird is compatible with other promise libraries, but would create an additional dependency that users of the library would have to install; it could alternatively be used only for tests and the dependency saved, but that would deny developers of its additional features

andrewjaykeller commented 8 years ago

Yea but it wouldn't result in a breaking change right

baffo32 commented 8 years ago

It would break obscure uses that don't limit themselves to the public promise API specification.

Right now I'm working on a change that uses bluebird only for testing.

baffo32 commented 8 years ago

I'll close this since it's in tests now. I think it could moved to be used fully internally no problem.