Write Promises Resolve When Write Completes

openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards

https://www.npmjs.com/package/openbci

138 stars 50 forks source link

Write Promises Resolve When Write Completes #124

Closed baffo32 closed 8 years ago

baffo32 commented 8 years ago

Addresses #91 . Promises returned by write calls now do not resolve until the data has been physically sent to the board.

I have not quite gotten the coverage up for this yet.

codecov-io commented 8 years ago

Current coverage is 94.40% (diff: 95.71%)

Merging #124 into development will decrease coverage by 0.04%

@@           development       #124   diff @@
=============================================
  Files                4          4          
  Lines             2273       2271     -2   
  Methods            136        135     -1   
  Messages             0          0          
  Branches           487        489     +2   
=============================================
- Hits              2147       2144     -3   
- Misses             126        127     +1   
  Partials             0          0

Powered by Codecov. Last update c696d4f...d4799dd

andrewjaykeller commented 8 years ago

We should update the readme too